benwtrent opened a new issue, #14407: URL: https://github.com/apache/lucene/issues/14407
### Description With the new HNSW merger logic, it seems we have some test failures with how it interacts with BP reordering, etc. ``` java.lang.IllegalStateException: The heap is empty at org.apache.lucene.core@11.0.0-SNAPSHOT/org.apache.lucene.util.LongHeap.pop(LongHeap.java:111) at org.apache.lucene.core@11.0.0-SNAPSHOT/org.apache.lucene.util.hnsw.UpdateGraphsUtils.computeJoinSet(UpdateGraphsUtils.java:59) at org.apache.lucene.core@11.0.0-SNAPSHOT/org.apache.lucene.util.hnsw.MergingHnswGraphBuilder.updateGraph(MergingHnswGraphBuilder.java:144) at org.apache.lucene.core@11.0.0-SNAPSHOT/org.apache.lucene.util.hnsw.MergingHnswGraphBuilder.build(MergingHnswGraphBuilder.java:126) at org.apache.lucene.core@11.0.0-SNAPSHOT/org.apache.lucene.util.hnsw.IncrementalHnswGraphMerger.merge(IncrementalHnswGraphMerger.java:192) at org.apache.lucene.core@11.0.0-SNAPSHOT/org.apache.lucene.codecs.lucene99.Lucene99HnswVectorsWriter.mergeOneField(Lucene99HnswVectorsWriter.java:392) at org.apache.lucene.core@11.0.0-SNAPSHOT/org.apache.lucene.codecs.perfield.PerFieldKnnVectorsFormat$FieldsWriter.mergeOneField(PerFieldKnnVectorsFormat.java:128) at org.apache.lucene.core@11.0.0-SNAPSHOT/org.apache.lucene.codecs.KnnVectorsWriter.merge(KnnVectorsWriter.java:105) at org.apache.lucene.core@11.0.0-SNAPSHOT/org.apache.lucene.index.SegmentMerger.mergeVectorValues(SegmentMerger.java:271) at org.apache.lucene.core@11.0.0-SNAPSHOT/org.apache.lucene.index.SegmentMerger.mergeWithLogging(SegmentMerger.java:314) at org.apache.lucene.core@11.0.0-SNAPSHOT/org.apache.lucene.index.SegmentMerger.merge(SegmentMerger.java:158) at org.apache.lucene.core@11.0.0-SNAPSHOT/org.apache.lucene.index.IndexWriter.mergeMiddle(IndexWriter.java:5285) at org.apache.lucene.core@11.0.0-SNAPSHOT/org.apache.lucene.index.IndexWriter.merge(IndexWriter.java:4751) at org.apache.lucene.core@11.0.0-SNAPSHOT/org.apache.lucene.index.IndexWriter$IndexWriterMergeSource.merge(IndexWriter.java:6569) at org.apache.lucene.core@11.0.0-SNAPSHOT/org.apache.lucene.index.ConcurrentMergeScheduler.doMerge(ConcurrentMergeScheduler.java:668) at org.apache.lucene.core@11.0.0-SNAPSHOT/org.apache.lucene.index.ConcurrentMergeScheduler$MergeThread.run(ConcurrentMergeScheduler.java:729) ``` ### Gradle command to reproduce ``` ./gradlew :lucene:misc:test --tests "org.apache.lucene.misc.index.TestBPReorderingMergePolicy.testReorderDoesntHaveEnoughRAM" -Ptests.jvms=2 -Ptests.jvmargs= -Ptests.seed=8797E3B9BBE4C3ED -Ptests.useSecurityManager=true -Ptests.gui=true -Ptests.file.encoding=ISO-8859-1 -Ptests.vectorsize=default -Ptests.forceintegervectors=false ``` ``` ./gradlew :lucene:misc:test --tests "org.apache.lucene.misc.index.TestBPReorderingMergePolicy.testReorderOnAddIndexes" -Ptests.jvms=2 -Ptests.jvmargs= -Ptests.seed=8797E3B9BBE4C3ED -Ptests.useSecurityManager=true -Ptests.gui=true -Ptests.file.encoding=ISO-8859-1 -Ptests.vectorsize=default -Ptests.forceintegervectors=false ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org