rmuir commented on issue #14257: URL: https://github.com/apache/lucene/issues/14257#issuecomment-2754226935
I played with this a bit and reduced noise in two ways: Original file: 113 files changed, 3656 insertions(+), 5216 deletions(-) 1. Disable reformatting of Apache License header: ```xml <setting id="org.eclipse.jdt.core.formatter.comment.format_header" value="false"/> ``` 93 files changed, 2525 insertions(+), 3861 deletions(-) 2. Disable reformatting of javadocs comments We could fight it, but my goal is to move them all to markdown format which google doesn't support anyway. Most differences are in things such as indentation of html tags. So the differences are just not relevant and create noise when doing comparison: ```xml <setting id="org.eclipse.jdt.core.formatter.comment.format_javadoc_comments" value="false"/> ``` 75 files changed, 1922 insertions(+), 3380 deletions(-) Eclipse has a lot of options and I think this file is just out of date. With the unnecessary noise out of the way, it is a matter of exploring all the settings and trying to reduce the differences more. I'm guessing there would always be differences, but it would be nice to minimize them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org