jpountz commented on code in PR #14365:
URL: https://github.com/apache/lucene/pull/14365#discussion_r2004331440
##########
lucene/core/src/java/org/apache/lucene/util/DocIdSetBuilder.java:
##########
@@ -47,6 +47,8 @@ public sealed interface BulkAdder permits FixedBitSetAdder,
BufferAdder {
void add(IntsRef docs);
void add(DocIdSetIterator iterator) throws IOException;
+
+ void add(IntsRef docs, int docLowerBoundExclusive);
Review Comment:
nit: I'd prefer the lower bound to be inclusive, it's more consistent with
e.g. DocIdSetIterator#advance(target) where the target is inclusive as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
