gf2121 commented on PR #14203: URL: https://github.com/apache/lucene/pull/14203#issuecomment-2727214320
> Sorry for making it hard for you to move this PR forward, I was a bit annoyed that we needed something complicated to speed things up, I like the simplicity of specializedDecodeMaskInRemainder. No apologies needed, it was exciting to play with the asm code, vectorize loops and make the code simpler! I learned so much through these iterations :) > In my opinion, it's good enough the way things are today as the default codec doesn't allow configuring the number of points per leaf node. LGTM. IMO we should bind OpenStreet benchmark to DEFAULT_MAX_POINTS_IN_LEAF_NODE after this get merged. https://github.com/mikemccand/luceneutil/blob/9724b69c9ef53715dae27baa3493a0ee7949748e/src/main/perf/IndexAndSearchOpenStreetMaps.java#L542 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
