jpountz commented on code in PR #14312:
URL: https://github.com/apache/lucene/pull/14312#discussion_r1987222711
##########
lucene/core/src/java/org/apache/lucene/search/DenseConjunctionBulkScorer.java:
##########
@@ -117,6 +107,65 @@ private static int advance(FixedBitSet set, int i) {
}
}
+ private int scoreWindow(
+ LeafCollector collector, Bits acceptDocs, List<DocIdSetIterator>
iterators, int min, int max)
+ throws IOException {
+
+ // Advance all iterators to the first doc that is greater than or equal to
min. This is
+ // important as this is the only place where we can take advantage of a
large gap between
+ // consecutive matches in any clause.
+ for (DocIdSetIterator iterator : iterators) {
+ if (iterator.docID() >= min) {
+ min = iterator.docID();
+ } else {
+ min = iterator.advance(min);
+ }
+ }
+ if (min >= max) {
+ return min;
+ }
+
+ int bitsetWindowMax = (int) Math.min(max, (long) min + WINDOW_SIZE);
+
+ if (acceptDocs == null) {
+ int minDocIDRunEnd = max;
+ for (DocIdSetIterator iterator : iterators) {
+ if (iterator.docID() > min) {
+ minDocIDRunEnd = min;
+ break;
+ } else {
+ minDocIDRunEnd = Math.min(minDocIDRunEnd, iterator.docIDRunEnd());
+ }
+ }
+
+ if (minDocIDRunEnd >= bitsetWindowMax) {
Review Comment:
I would like to avoid collecting tiny windows of doc IDs at once, so that
collectors can feel free to apply logic that has some overhead in
`LeafCollector#collect(DocIdStream)` (e.g.
https://github.com/apache/lucene/pull/14273/files#diff-05525bb5769d4251279bcd9c76d259f8eb451a16075af357e69bd98890c3db5bR257).
But I applied your suggestion of relaxing the window size a bit in the case
when everything matches.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
