rmuir commented on PR #14311: URL: https://github.com/apache/lucene/pull/14311#issuecomment-2694568500
@renatoh oh, sorry for the slow feedback, did not realize you had deconflicted it. changes look good to me. I wish there was a way to really use a `@deprecated/@Deprecated` here, but I haven't dug in, it may be challenging due to telescoping ctor. If you have ideas on how to solve it, let me know, otherwise I think we should just merge the change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
