renatoh commented on PR #14278: URL: https://github.com/apache/lucene/pull/14278#issuecomment-2679176831
> looks good to me. I wonder about the name of the parameter, maybe "greedy" would be more intuitive as a way to describe what it is doing? not saying "consumeChars" is a good name, happy to change it. but "greedy", as we know it from Regex, is something else, we are not capturing as much as possible, we are skipping forward on a match what do you think of "reuseChars" with a default of true? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
