pseudo-nymous commented on code in PR #14279: URL: https://github.com/apache/lucene/pull/14279#discussion_r1967532868
########## .github/workflows/verify-changelog-and-set-milestone.yml: ########## @@ -0,0 +1,100 @@ +name: "Change Log Entry Verifier and Milestone Setter" +run-name: Change log entry verifier and milestone setter +on: + - pull_request_target + +env: + GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} + ISSUE: ${{ github.event.issue.html_url }} + ESCAPE_HATCH: ${{ '__NA__' }} + CHANGE_LOG_FILE: ${{ 'lucene/CHANGES.txt' }} + +jobs: + changelog-verifier-and-milestone-setter: + name: Verify Change Log Entry and Set Milestone + runs-on: ubuntu-latest + + steps: + - name: Checkout repository + uses: actions/checkout@v4 + with: + fetch-depth: 2 + + - name: ChangeLog Entry Verifier and Milestone Setter + run: | + echo "################## STEP 1 ##################" + echo "Checking for escape hatch in the top comment" Review Comment: To clarify, here top comment refers to the description itself. But I also like the idea of adding a `skip changelog` label to pr to skip the workflow. This way it's more intuitive rather than adding a specific skip hatch string in description. I'll update with this change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org