gf2121 commented on code in PR #14269:
URL: https://github.com/apache/lucene/pull/14269#discussion_r1965326705
##########
lucene/core/src/java/org/apache/lucene/search/DocIdSetIterator.java:
##########
@@ -224,7 +248,7 @@ protected final int slowAdvance(int target) throws
IOException {
* </pre>
*
* <p><b>Note</b>: {@code offset} must be less than or equal to the {@link
#docID() current doc
- * ID}.
+ * ID}. Behaviour is undefined if this iterator is unpositioned or exhausted.
Review Comment:
> I agree that it should never be called if the iterator is unpositioned,
but exhausted should be fine?
+1
> Should we assert this in AssertingScorer? (or is it already checked?)
Yes, already checked.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
