gsmiller commented on PR #14238: URL: https://github.com/apache/lucene/pull/14238#issuecomment-2666152482
@houserjohn it looks like the randomized testing failed in some recent runs (see: [here](https://github.com/apache/lucene/actions/runs/13388526608/job/37390674327)): ``` TestDynamicRangeUtil > testComputeDynamicNumericRangesWithRandomValues FAILED java.lang.AssertionError at __randomizedtesting.SeedInfo.seed([50D292E371306B1:9BCACADABDA87D35]:0) at junit@4.13.1/org.junit.Assert.fail(Assert.java:87) at junit@4.13.1/org.junit.Assert.assertTrue(Assert.java:42) at junit@4.13.1/org.junit.Assert.assertTrue(Assert.java:53) ... 2> NOTE: reproduce with: gradlew test --tests TestDynamicRangeUtil.testComputeDynamicNumericRangesWithRandomValues -Dtests.seed=50D292E371306B1 -Dtests.locale=kl-Latn-GL -Dtests.timezone=America/Mendoza -Dtests.asserts=true -Dtests.file.encoding=UTF-8 2> NOTE: test params are: codec=Asserting(Lucene101): {}, docValues:{}, maxPointsInLeafNode=1816, maxMBSortInHeap=7.672327997432254, sim=Asserting(RandomSimilarity(queryNorm=false): {}), locale=kl-Latn-GL, timezone=America/Mendoza 2> NOTE: Mac OS X 14.7.2 aarch64/Eclipse Adoptium 21.0.5 (64-bit)/cpus=3,threads=1,free=190300384,total=268435456 2> NOTE: All tests run in this JVM: [TestDrillDownQuery, TestDrillSideways, TestFacetQuery, TestFacetUtils, TestFacetsConfig, TestLongValueFacetCounts, TestMultiDoubleValuesSource, TestMultiLongValuesSource, TestMultipleIndexFields, TestParallelDrillSideways, TestRandomSamplingFacetsCollector, TestStringValueFacetCounts, TestExactFacetSetMatcher, TestMatchingFacetSetsCounts, TestRangeFacetSetMatcher, TestDynamicRangeUtil] ``` (thanks @stefanvodita for catching this!) The good news is this reproduced for me locally with the seed from the linked failure: `./gradlew test --tests TestDynamicRangeUtil.testComputeDynamicNumericRangesWithRandomValues -Dtests.seed=50D292E371306B1 -Dtests.locale=kl-Latn-GL -Dtests.timezone=America/Mendoza -Dtests.asserts=true -Dtests.file.encoding=UTF-8` @stefanvodita reverted this change and the corresponding back port already (see #14252 and #14253). So I think the right next steps here are to figure out what's causing the test failure (did randomization catch an actual bug in the implementation, or is there an invalid test assertion somewhere?), then reopen a new PR with this change that includes the fix. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
