dweiss opened a new pull request, #14246: URL: https://github.com/apache/lucene/pull/14246
Fixes #14235 Sorry this took surprisingly long. I've tried to clean up a few things along the way: * the repositories are now pulled at constant refs embedded inside the gradle file, unless an explicit reference is passed using gradle properties for each repository. So `-Ptests.hunspell.libreoffice.ref=master` will test against the master branch (or any other sha provided there). For woorm, it's `-Ptests.hunspell.woorm.ref=main`. * I've added a scheduled workflow run every Monday against latest dev branches of both projects. I also cleaned up gradle scripts a bit. * removed the separate test task and replaced it with a property that controls whether we pull/ test against remote repositories: `-Ptests.hunspell.regressions=true`. The separate task wasn't configured properly (it wasn't running in module mode) and in general I think it's better to just keep the 'test' task for running tests. * gh workflows run just the `TestAllDictionaries` class, not everything. I also had to open up some core packages to the test framework - this is a side effect of TestAllDictionaries measuring memory of Dictionary objects it creates. I think it'd be nice to make Dictionary implement Accountable and remove opens statements but it's probably a follow up issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
