risdenk commented on code in PR #14221:
URL: https://github.com/apache/lucene/pull/14221#discussion_r1951627505
##########
lucene/analysis/smartcn/src/java/org/apache/lucene/analysis/cn/smart/AnalyzerProfile.java:
##########
@@ -34,45 +34,44 @@
public class AnalyzerProfile {
/** Global indicating the configured analysis data directory */
- public static String ANALYSIS_DATA_DIR = "";
+ public static final String ANALYSIS_DATA_DIR;
static {
- init();
+ ANALYSIS_DATA_DIR = init();
Review Comment:
Does this need to be in the static block? cant the line above just be
`public static final String ANALYSIS_DATA_DIR = init();`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
