cgejian commented on PR #14163: URL: https://github.com/apache/lucene/pull/14163#issuecomment-2644414098
> > I don't think we should merge this change, but it's good that you were able to use it to confirm that merging would reclaim these deleted docs. > > Can you add your data about this issue to #13226? There is a smell merging not keeping up or a bad interaction between the merge policy and soft deletes. > > @jpountz During the production environment validation of this PR, the docs.deleted count was reduced from billions to millions, and the index storage size was decreased by five times, resulting in excellent performance. > > This PR functions as a tool, allowing users to decide whether to use it without impacting the core Lucene merge process. Therefore, I believe this PR should be considered for merging. > > Regarding your inquiry, "Can you add your data about this issue to #13226," due to the constraints of the production environment, enabling InfoStream logging is quite cumbersome. As a result, there are no more detailed logs available beyond the segments information. @jpountz This is my first time submitting a PR to the Lucene project, and I'm not very clear about the conditions under which a PR can be merged. Could you please tell me if this PR can be merged? Looking forward to your reply, thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
