gsmiller commented on PR #13974: URL: https://github.com/apache/lucene/pull/13974#issuecomment-2643826042
Thanks @mkhludnev . 1. I'm not as worried about getting the API perfect with this initial commit. One benefit of doing this in `sandbox` is that we can iterate on this in breaking ways without being too concerned. So if you're planning to add more use-cases, I can imagine this evolving and getting iterated on over time. So I wasn't going to comment on the API too much right now since this is in `sandbox`. 2. More testing, and toString is great :) 3. I think what you're doing with skipper already is correct. It's possible you could do more, but I'd save that for a follow up. The skipper gives you the min and max values represented by a range of docs. So what you're essentially doing right now is saying that if a given doc falls into a skip interval that doesn't intersect with the full min-max range that covers all of your multi-ranges, then it cannot match any of your ranges so you can skip it without loading its doc value and checking explicitly. If you're unsure of what you're doing with skipper though, you could also remove it as an optimization for now and add it back in separately (e.g., if you're concerned it might be incorrect). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
