risdenk commented on PR #14201: URL: https://github.com/apache/lucene/pull/14201#issuecomment-2637881979
This looks fine. I do think there are new rules that could be disabled like [DefaultLocale](https://errorprone.info/bugpattern/DefaultLocale) We were keeping a list https://github.com/apache/lucene/blob/main/gradle/validation/error-prone.gradle#L73 I understand what a PITA it is to keep that up to date and disable the unneeded rules though. I can take a stab at it tomorrow most likely if it would help. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
