mayya-sharipova commented on code in PR #14191: URL: https://github.com/apache/lucene/pull/14191#discussion_r1939834681
########## lucene/core/src/java/org/apache/lucene/search/knn/MultiLeafKnnCollector.java: ########## @@ -89,6 +91,24 @@ public MultiLeafKnnCollector( this.nonCompetitiveQueue = new FloatHeap(Math.max(1, Math.round((1 - greediness) * k))); this.updatesQueue = new FloatHeap(k); this.updatesScratch = new float[k]; + this.frozen = frozen; Review Comment: It looks like we never use data from global queue, we can the following: if (frozen) { cachedGlobalMinSim = globalSimilarityQueue.peek(); } -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org