cpoerschke commented on code in PR #14170:
URL: https://github.com/apache/lucene/pull/14170#discussion_r1933828372
##########
lucene/join/src/java/org/apache/lucene/search/join/DiversifyingNearestChildrenKnnCollector.java:
##########
@@ -42,7 +43,20 @@ class DiversifyingNearestChildrenKnnCollector extends
AbstractKnnCollector {
* @param parentBitSet The leaf parent bitset
*/
public DiversifyingNearestChildrenKnnCollector(int k, int visitLimit, BitSet
parentBitSet) {
- super(k, visitLimit);
+ this(k, visitLimit, null, parentBitSet);
+ }
+
+ /**
+ * Create a new object for joining nearest child kNN documents with a parent
bitset
+ *
+ * @param k The number of joined parent documents to collect
+ * @param visitLimit how many child vectors can be visited
+ * @param parentBitSet The leaf parent bitset
+ * @param searchStrategy The search strategy to use
Review Comment:
```suggestion
* @param searchStrategy The search strategy to use
* @param parentBitSet The leaf parent bitset
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
