benwtrent commented on code in PR #14147:
URL: https://github.com/apache/lucene/pull/14147#discussion_r1925317415
##########
lucene/core/src/java/org/apache/lucene/search/knn/MultiLeafKnnCollector.java:
##########
@@ -77,6 +76,7 @@ public MultiLeafKnnCollector(
int interval,
BlockingFloatHeap globalSimilarityQueue,
AbstractKnnCollector subCollector) {
+ super(subCollector);
Review Comment:
For this particular use, it needs to be a `AbstractKnnCollector` which has
different methods than the regular `KnnCollector`. So, changing the visibility
doesn't really simplify things much.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
