jpountz commented on PR #14138: URL: https://github.com/apache/lucene/pull/14138#issuecomment-2592898984
This makes sense to me, if the `visit()` call is inlined, then feeding the IntsRef into either an int[] (`BufferAdder`) or a `FixedBitSet` (`BitSetAdder`) can be auto-vectorized. Otherwise it can't. This makes me wonder if we should instead introduce `BulkAdder#add(IntsRef)` and implement these `visit(IntsRef)` methods by calling `adder.add(intsRef)` directly, this would make auto-vectorizing less likely to get disabled by an apparently innocent change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
