mikemccand commented on PR #13984: URL: https://github.com/apache/lucene/pull/13984#issuecomment-2573785203
Thank you for persisting on this important change @benchaplin! I applied this PR to my local Lucene clone and ran `CheckIndex` on the vector index created by [last night's nightly Lucene benchmarks](https://benchmarks.mikemccandless.com/) index but there was no new output covering the HNSW graph. I think the reason is because the benchmarks [create an index using `Lucene99HnswVectorsFormat`](https://github.com/mikemccand/luceneutil/blob/main/src/main/perf/Indexer.java#L477-L493) without the `PerField` wrapper. I think it'd be easy to also handle this case in your change? In addition to checking if the `PerFieldKnnVectorsFormat` is in use, you could check whether the `reader.getVectorReader() instanceof HnswGraphProvider`? So both routes (per-field case and not per-field case) could yield an `HnswGraphProvider` which you can then check for integrity ... It's OK to do this in a follow-on issue too... either way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
