msokolov commented on PR #14097: URL: https://github.com/apache/lucene/pull/14097#issuecomment-2572995493
Right, I was kind of hoping @jpountz would review, but perhaps he's out for vacation. Most of this has already been seen and he approved the earlier PR. The main new thing here that might be controversial is the refactoring so that this reorderer shares a common interface (and some implementation, for less code repetition) with the pre-existing BPIndexReorderer. I think I'll go ahead and commit, but not backport yet, so we can get some runs in the test machines, and if we later decide we want to revise that approach we still can. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
