ChrisHegarty commented on code in PR #13998:
URL: https://github.com/apache/lucene/pull/13998#discussion_r1850657822


##########
lucene/core/src/java/org/apache/lucene/store/IndexInput.java:
##########
@@ -226,4 +227,17 @@ public String toString() {
    * @param length the number of bytes to prefetch
    */
   public void prefetch(long offset, long length) throws IOException {}
+
+  /**
+   * Returns a hint whether all the contents of this input are resident in 
physical memory. It's a
+   * hint because the operating system may have paged out some of the data by 
the time this method
+   * returns. If the optional is true, then it's likely that the contents of 
this input are resident
+   * in physical memory. A value of false does not imply that the contents are 
not resident in
+   * physical memory. An empty optional is returned if it is not possible to 
determine.

Review Comment:
   I added a note about the time complexity.   I'd like to keep the tri-state 
of the return type, at least for now. Since I think will be useful to know that 
the isLoaded-ness or not, is determinable or not.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to