ChrisHegarty commented on code in PR #13985:
URL: https://github.com/apache/lucene/pull/13985#discussion_r1842167895
##########
lucene/core/src/java/org/apache/lucene/codecs/KnnVectorsReader.java:
##########
@@ -123,4 +123,11 @@ public abstract void search(
public KnnVectorsReader getMergeInstance() {
return this;
}
+
+ /**
+ * Optional: reset or close merge resources used in the reader
+ *
+ * <p>The default implementation is empty
+ */
+ public void finishMerge() throws IOException {}
Review Comment:
> I wonder if we should reuse the close() method of merge instances for
this, what do you think ... ?
It might be possible to use `close` here, if we override it to restore the
previous read advice, and ensure that the merge calls close. Additionally,
either avoid closing the underlying index input or slice the input upon
creation of the new instance. (closing the slice will not close the underlying
input).
I see that this is all per-thread, so this may be fine. But just to say it
explicitly here, changing the read advice, whether it be on a slice or not,
will affect all instances that share the underlying index. This should be fine
- since the reader is just being used for merging at this point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
