jpountz commented on code in PR #13961: URL: https://github.com/apache/lucene/pull/13961#discussion_r1820458842
########## lucene/core/src/java/org/apache/lucene/index/SlowCompositeCodecReaderWrapper.java: ########## @@ -377,7 +376,7 @@ private static class SlowCompositeDocValuesProducerWrapper extends DocValuesProd private final CodecReader[] codecReaders; private final DocValuesProducer[] producers; private final int[] docStarts; - private final Map<String, OrdinalMap> cachedOrdMaps = new HashMap<>(); + private final IntObjectHashMap<OrdinalMap> cachedOrdMaps = new IntObjectHashMap<>(); Review Comment: I would rather keep this one keyed on the String field name since there's some ambiguity about whether it doc values sohuld be retrieved by segment field infos or by merged field infos. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org