ljak opened a new pull request, #13944:
URL: https://github.com/apache/lucene/pull/13944

   Since https://github.com/apache/lucene/pull/110, the disjuncts elements of 
DisjunctionMaxQueries don't have an order anymore, which is impacting the 
`toString` method. In isolation, that does not matter. But, in Solr, when the 
debug component is needed for a distributed query, every shard can return a 
different toString representation of the same query... and the different 
toString keys of the debug response will have an array value, containing those 
different representations (instead of having one value for one same 
representation).
   
   Example with the `parsedquery_toString` key (of a json response within Solr):
   `parsedquery_toString":["((docIdentifiers:\"Okarandeep Osingh\" 
docIdentifiers:Otest) | (docTitle:\"Okarandeep Osingh\" docTitle:Otest) | 
(docBody:\"Okarandeep Osingh\" docBody:Otest))","((docBody:\"Okarandeep 
Osingh\" docBody:Otest) | (docTitle:\"Okarandeep Osingh\" docTitle:Otest) | 
(docIdentifiers:\"Okarandeep Osingh\" docIdentifiers:Otest))"]`
   
   When PR110 was merged, Solr adapted its unit tests this way: 
https://github.com/apache/solr/pull/117 but, later on within Lucene, the 
toString method of DisjuctionIntervalsSource was adapted in prevision of a 
potential similar future change: https://github.com/apache/lucene/pull/193. 
   
   I adapted the toString method of DisjunctionMaxQueries similarly to this PR.
   
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to