msokolov commented on PR #13872: URL: https://github.com/apache/lucene/pull/13872#issuecomment-2430042116
With the most recent commit I saw these luceneutil/knnPerfTest.py results: ## 1. baseline ``` recall latency (ms) nDoc topK fanout maxConn beamWidth quantized index s force merge s num segments index size (MB) 0.816 0.294 1500000 10 6 32 50 no 341.37 110.92 1 1534.03 0.811 0.308 1500000 10 6 32 50 7 bits 346.68 93.22 1 1906.16 0.786 0.288 1500000 10 6 32 50 4 bits 346.28 89.15 1 1906.10 ``` ## this change with defaults (no command line flags) ``` recall latency (ms) nDoc topK fanout maxConn beamWidth quantized index s force merge s num segments index size (MB) 0.817 0.304 1500000 10 6 32 50 no 344.11 111.70 1 1533.94 0.812 0.231 1500000 10 6 32 50 7 bits 354.29 89.76 1 1906.16 0.785 0.239 1500000 10 6 32 50 4 bits 352.37 89.01 1 1906.12 ``` ## This change with vector api enabled: ``` recall latency (ms) nDoc topK fanout maxConn beamWidth quantized index s force merge s num segments index size (MB) 0.817 0.247 1500000 10 6 32 50 no 0.00 0.17 1 1533.94 0.812 0.282 1500000 10 6 32 50 7 bits 0.00 0.17 1 1906.16 0.785 0.207 1500000 10 6 32 50 4 bits 0.00 0.17 1 1906.12 ``` ## This change with vector api and enable-native-access ``` recall latency (ms) nDoc topK fanout maxConn beamWidth quantized index s force merge s num segments index size (MB) 0.817 0.246 1500000 10 6 32 50 no 0.00 0.17 1 1533.94 0.812 0.290 1500000 10 6 32 50 7 bits 0.00 0.17 1 1906.16 0.785 0.206 1500000 10 6 32 50 4 bits 0.00 0.18 1 1906.12 ``` So I think there is some slowdown in the quantized indexing. I think we need to find a solution for the over-allocations due to having moved this logic from ScorerSupplier to Scorer. The best idea I have is to make Scorers mutable and supply them with new target vectors as needed. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org