ChrisHegarty commented on issue #13808:
URL: https://github.com/apache/lucene/issues/13808#issuecomment-2360658830

   git bisect shows this:
   
   ```
   ad09777867d10cbaa2a9582bb49a2de5ad7748ba is the first bad commit
   commit ad09777867d10cbaa2a9582bb49a2de5ad7748ba
   Author: Benjamin Trent <ben.w.tr...@gmail.com>
   Date:   Wed Sep 11 09:14:50 2024 -0400
   
       This commit adds a new test CMS that always provides intra-merge 
parallelism (#13475)
       
       @iverase has uncovered a potential issue with intra-merge CMS 
parallelism.
       
       This commit helps expose this problem by forcing tests to use 
intra-merge parallelism instead of always (well, usually) delegating to a 
SameThreadExecutorService.
       
       When intra-merge parallelism is used, norms, doc_values, stored_values, 
etc. are all merged in a separate thread than the thread that was used to 
construct their merge optimized instances.
       
       This trips assertions numerous assertions in AssertingCodec.assertThread 
where we assume that the thread that called getMergeInstance() is also the 
thread getting the values to merge.
       
       In addition to the better testing, this corrects poor merge state 
handling in the event of parallelism.
   
    lucene/CHANGES.txt                                 |  2 +
    .../java/org/apache/lucene/index/MergeState.java   | 53 
+++++++++++++++++++++-
    .../org/apache/lucene/index/SegmentMerger.java     | 41 ++++++++++-------
    .../lucene/index/TestIndexWriterForceMerge.java    |  1 +
    .../apache/lucene/tests/util/LuceneTestCase.java   | 21 +++++++--
    5 files changed, 98 insertions(+), 20 deletions(-)
   bisect found first bad commit
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to