msokolov commented on PR #13779: URL: https://github.com/apache/lucene/pull/13779#issuecomment-2358728676
FWIW I tried removing `copy()` and using caller-supplied storage in `vectorValue`. In many ways this looks nicer, but it leads to substantial slowdown in indexing/merging because of the additional copy required, so I think it's not really viable. We could provide *both* `vectorValue(int)` and `vectorValue(int, float[])` and avoid `copy()` that way. Maybe that's best -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
