Mikep86 commented on code in PR #13785:
URL: https://github.com/apache/lucene/pull/13785#discussion_r1761059326
##########
lucene/join/src/test/org/apache/lucene/search/join/TestBlockJoinBulkScorer.java:
##########
@@ -283,7 +292,33 @@ public void collect(int doc) throws IOException {
null,
0,
NO_MORE_DOCS);
- assertEquals(expectedScores, actualScores);
+
+ if (expectedScoresList.size() == 1) {
+ assertEquals(expectedScoresList.getFirst(), actualScores);
+ } else {
+ assertEqualsToOneOf(expectedScoresList, actualScores);
+ }
Review Comment:
It should and I originally did that, but if you use `assertEquals` there are
nicer IDE integrations for value comparison on failure. Given that this method
is called with a single map of expected scores in nearly all cases, I tried to
preserve that functionality. This could help in the case of a failure in
`testScoreRandomIndices`, which could have a large random score map.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
