gsmiller commented on PR #13693: URL: https://github.com/apache/lucene/pull/13693#issuecomment-2351893751
Thanks so much @iverase for the feedback! I wanted to approach this as a query rewrite initially, but I'm not sure it's all the feasible. The issue is that the ordinal mapping is segment-specific (potentially, at lest), and the rewrite would have to inspect all the segment-level doc values to determine if the range is contiguous. That's the issue I ran into at least. I also don't love exposing the scoring implementation publicly. It really is an internal implementation detail. Maybe there's a better way to approach this? I'm open to suggestions. I'm also open to dropping this if we think the exposure isn't work the semi-rare likelihood of the optimization. I just don't like leaving optimizations "on the table" when there's an opportunity to improve. Maybe I'm overlooking an obvious way to take a query rewrite approach? If so, please let me know. Happy to explore other avenues. Thanks again! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
