javanna commented on code in PR #13777:
URL: https://github.com/apache/lucene/pull/13777#discussion_r1757481284
##########
lucene/core/src/java/org/apache/lucene/search/TopScoreDocCollector.java:
##########
@@ -254,10 +254,9 @@ protected void updateMinCompetitiveScore(Scorable scorer)
throws IOException {
totalHitsRelation = TotalHits.Relation.GREATER_THAN_OR_EQUAL_TO;
minCompetitiveScore = localMinScore;
if (minScoreAcc != null) {
- // we don't use the next float but we register the document
- // id so that other leaves can require it if they are after
- // the current maximum
- minScoreAcc.accumulate(docBase, pqTop.score);
+ // we don't use the next float but we register the document id so
that other leaves or
+ // leaf partitions can require it if they are after the current
maximum
+ minScoreAcc.accumulate(docBase + pqTop.doc, pqTop.score);
Review Comment:
ah good point!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
