javanna commented on code in PR #13606:
URL: https://github.com/apache/lucene/pull/13606#discussion_r1756897923
##########
lucene/core/src/java/org/apache/lucene/search/HitsThresholdChecker.java:
##########
@@ -24,6 +24,10 @@ abstract class HitsThresholdChecker {
/** Implementation of HitsThresholdChecker which allows global hit counting
*/
private static class GlobalHitsThresholdChecker extends HitsThresholdChecker
{
private final LongAdder globalHitCount = new LongAdder();
+ // Cache whether the threshold has been reached already. It is not
volatile or synchronized on
+ // purpose to contain the overhead of reading the value similarly to what
String#hashCode()
+ // does. This does not affect correctness.
+ private boolean thresholdReached = false;
Review Comment:
I bumped into this only now, and I was wondering: this is mutable state
accessed concurrently by multiple threads? If so can it be a primitive boolean
without any thread-safety measure?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
