javanna commented on PR #13775: URL: https://github.com/apache/lucene/pull/13775#issuecomment-2346263866
Thanks for clarifying! But then is it a feature that it goes out of memory now? Especially given that it's a side by side comparison, and what causes the OOM is the ordinary top docs search, and not the large num hits collector, which suggests that is indeed more optimized in terms of memory allocated. I would think that if memory usage is what we want to test, we should probably have a different test? Or maybe it makes sense to lower the threshold only for the top docs collector part, which is the one that causes issues and we are only using to compare final results? Note that the second search does not even use concurrency as it uses the deprecated `search(Query, Collector)` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
