jpountz commented on code in PR #13692:
URL: https://github.com/apache/lucene/pull/13692#discussion_r1733487895
##########
lucene/core/src/java/org/apache/lucene/codecs/lucene912/Lucene912PostingsReader.java:
##########
@@ -509,15 +547,14 @@ private void refillRemainder() throws IOException {
if (docFreq == 1) {
docBuffer[0] = singletonDocID;
freqBuffer[0] = totalTermFreq;
- docBuffer[1] = NO_MORE_DOCS;
docCountUpto++;
} else {
// Read vInts:
PostingsUtil.readVIntBlock(docIn, docBuffer, freqBuffer, left,
indexHasFreq, needsFreq);
prefixSum(docBuffer, left, prevDocID);
- docBuffer[left] = NO_MORE_DOCS;
docCountUpto += left;
}
+ Arrays.fill(docBuffer, left, docBuffer.length, NO_MORE_DOCS);
Review Comment:
Here are the results:
```
TaskQPS baseline StdDevQPS
my_modified_version StdDev Pct diff p-value
CountOrHighMed 167.66 (7.0%) 161.29
(7.4%) -3.8% ( -17% - 11%) 0.096
Prefix3 231.74 (5.5%) 224.18
(6.1%) -3.3% ( -14% - 8%) 0.074
CountOrHighHigh 49.49 (16.9%) 48.04
(17.9%) -2.9% ( -32% - 38%) 0.595
HighTermTitleBDVSort 17.79 (6.3%) 17.39
(5.0%) -2.2% ( -12% - 9%) 0.214
OrNotHighMed 306.15 (6.2%) 301.76
(5.8%) -1.4% ( -12% - 11%) 0.447
LowTerm 823.11 (6.0%) 814.89
(5.8%) -1.0% ( -12% - 11%) 0.591
Wildcard 81.54 (4.7%) 81.16
(4.0%) -0.5% ( -8% - 8%) 0.735
MedTerm 547.52 (7.0%) 545.34
(8.0%) -0.4% ( -14% - 15%) 0.868
MedSloppyPhrase 7.83 (5.2%) 7.82
(5.8%) -0.1% ( -10% - 11%) 0.942
PKLookup 286.70 (2.5%) 286.39
(3.1%) -0.1% ( -5% - 5%) 0.903
CountPhrase 6.59 (3.3%) 6.59
(4.1%) -0.0% ( -7% - 7%) 0.980
MedPhrase 46.01 (9.6%) 46.03
(3.6%) 0.0% ( -12% - 14%) 0.986
OrStopWords 33.71 (5.6%) 33.78
(5.8%) 0.2% ( -10% - 12%) 0.909
HighTerm 473.92 (8.0%) 474.99
(8.2%) 0.2% ( -14% - 17%) 0.929
Or3Terms 252.82 (3.6%) 253.40
(3.2%) 0.2% ( -6% - 7%) 0.829
OrHighLow 779.20 (2.8%) 781.17
(2.8%) 0.3% ( -5% - 6%) 0.777
Respell 49.87 (2.7%) 50.01
(2.5%) 0.3% ( -4% - 5%) 0.736
LowSloppyPhrase 18.60 (3.5%) 18.66
(3.9%) 0.3% ( -6% - 8%) 0.787
AndHighMed 132.84 (2.4%) 133.32
(1.7%) 0.4% ( -3% - 4%) 0.583
HighSloppyPhrase 15.25 (4.0%) 15.31
(4.1%) 0.4% ( -7% - 8%) 0.742
HighTermTitleSort 138.90 (2.4%) 139.48
(2.2%) 0.4% ( -4% - 5%) 0.567
Fuzzy1 103.74 (2.6%) 104.22
(1.8%) 0.5% ( -3% - 5%) 0.516
MedIntervalsOrdered 3.21 (7.0%) 3.23
(7.2%) 0.5% ( -12% - 15%) 0.817
OrHighHigh 74.58 (3.9%) 74.97
(4.7%) 0.5% ( -7% - 9%) 0.693
LowIntervalsOrdered 23.64 (5.2%) 23.78
(4.7%) 0.6% ( -8% - 11%) 0.709
OrHighNotLow 376.98 (7.8%) 379.21
(8.1%) 0.6% ( -14% - 17%) 0.814
LowSpanNear 7.82 (1.8%) 7.88
(1.7%) 0.7% ( -2% - 4%) 0.209
HighTermMonthSort 2902.96 (5.7%) 2926.30
(6.0%) 0.8% ( -10% - 13%) 0.665
AndHighHigh 86.36 (1.9%) 87.14
(2.3%) 0.9% ( -3% - 5%) 0.176
And2Terms2StopWords 132.56 (3.5%) 133.76
(2.6%) 0.9% ( -4% - 7%) 0.347
And3Terms 124.51 (3.2%) 125.64
(2.2%) 0.9% ( -4% - 6%) 0.296
OrHighMed 249.41 (2.4%) 251.97
(3.8%) 1.0% ( -5% - 7%) 0.310
HighSpanNear 4.84 (2.2%) 4.89
(2.0%) 1.0% ( -3% - 5%) 0.128
OrHighNotMed 361.52 (7.3%) 365.54
(7.6%) 1.1% ( -12% - 17%) 0.637
Fuzzy2 67.15 (3.8%) 68.02
(1.5%) 1.3% ( -3% - 6%) 0.164
Or2Terms2StopWords 264.64 (2.9%) 268.12
(2.6%) 1.3% ( -4% - 7%) 0.131
HighIntervalsOrdered 4.01 (6.8%) 4.07
(5.6%) 1.4% ( -10% - 14%) 0.491
HighPhrase 38.37 (5.9%) 38.93
(2.6%) 1.4% ( -6% - 10%) 0.315
OrHighNotHigh 192.14 (7.1%) 195.02
(6.4%) 1.5% ( -11% - 16%) 0.483
MedSpanNear 9.03 (2.2%) 9.17
(2.2%) 1.6% ( -2% - 6%) 0.022
HighTermDayOfYearSort 776.53 (3.5%) 789.12
(3.6%) 1.6% ( -5% - 8%) 0.146
AndStopWords 30.04 (3.9%) 30.60
(2.8%) 1.9% ( -4% - 8%) 0.082
OrNotHighHigh 223.21 (7.0%) 227.77
(6.5%) 2.0% ( -10% - 16%) 0.337
TermDTSort 333.94 (7.0%) 341.36
(5.5%) 2.2% ( -9% - 15%) 0.263
OrHighRare 244.42 (10.1%) 250.18
(10.2%) 2.4% ( -16% - 25%) 0.463
OrNotHighLow 999.03 (3.6%) 1025.44
(4.4%) 2.6% ( -5% - 10%) 0.036
CountTerm 7229.95 (8.6%) 7423.29
(11.6%) 2.7% ( -16% - 25%) 0.408
AndHighLow 965.21 (4.0%) 994.65
(3.5%) 3.1% ( -4% - 10%) 0.010
LowPhrase 30.82 (8.4%) 31.77
(3.1%) 3.1% ( -7% - 15%) 0.128
CountAndHighMed 133.07 (1.3%) 138.93
(2.0%) 4.4% ( 1% - 7%) 0.000
IntNRQ 111.40 (25.8%) 117.21
(25.7%) 5.2% ( -36% - 76%) 0.522
CountAndHighHigh 48.04 (1.2%) 53.06
(2.3%) 10.5% ( 6% - 14%) 0.000
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
