ChrisHegarty commented on code in PR #13682:
URL: https://github.com/apache/lucene/pull/13682#discussion_r1728853946
##########
lucene/core/src/java/org/apache/lucene/store/MMapDirectory.java:
##########
@@ -312,6 +361,21 @@ public boolean getPreload() {
return preload == ALL_FILES;
}
+ /**
+ * Configures a grouping function for files that are part of the same
logical group. The gathering
+ * of files into a logical group is a hint that allows for better handling
of resources.
Review Comment:
Grouping is a **hint**, and therefore may be ignored by an implementation,
e.g. JDK 19 and 20 versions of the MemorySegment implementation. We could make
this more clear, but I'm on the fence about whether it's worth it or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
