mrhbj commented on PR #13666:
URL: https://github.com/apache/lucene/pull/13666#issuecomment-2296511386
you are right,i will change my commit messave,thanks
---Original---
From: "Michael ***@***.***>
Date: Mon, Aug 19, 2024 20:32 PM
To: ***@***.***>;
Cc: ***@***.******@***.***>;
Subject: Re: [apache/lucene] Make the code look simpler (PR #13666)
This looks good to me, but perhaps you could make the commit message more
descriptive of the actual change. If I read "make the code look simpler" I have
misgivings! Maybe mention the switch statement since that is the specific change
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
