jpountz commented on code in PR #13658:
URL: https://github.com/apache/lucene/pull/13658#discussion_r1718955964


##########
lucene/core/src/java/org/apache/lucene/codecs/lucene912/PostingIndexInput.java:
##########
@@ -50,6 +53,6 @@ public void decode(int bitsPerValue, long[] longs) throws 
IOException {
    * and store results into {@code longs}.
    */
   public void decodeAndPrefixSum(int bitsPerValue, long base, long[] longs) 
throws IOException {

Review Comment:
   I forgot to add a comment about that: `PostingsDecodingUtil` instances can 
only be retrieved from specific call sites, see 
`VectorizationProvider#ensureCaller`. So I needed to introduce some abstraction 
that could be used from the benchmark-jmh module. Before this PR, this didn't 
look too odd because this abstraction was also used in 
`Lucene912PostingsReader`, but indeed now it's only used by the benchmark-jmh 
module. I'll add a comment.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to