dweiss commented on issue #13638: URL: https://github.com/apache/lucene/issues/13638#issuecomment-2288034567
I compared main with 8f50976c268. When you list the plugins applied to the root project, it'll give you this: ``` class org.gradle.api.plugins.HelpTasksPlugin$Inject class org.gradle.buildinit.plugins.BuildInitPlugin$Inject class org.gradle.buildinit.plugins.WrapperPlugin$Inject class org.gradle.language.base.plugins.LifecycleBasePlugin$Inject class org.gradle.api.plugins.BasePlugin$Inject class org.gradle.api.plugins.JvmEcosystemPlugin$Inject class org.gradle.api.plugins.ReportingBasePlugin$Inject class org.gradle.api.plugins.JvmToolchainsPlugin$Inject class org.gradle.api.plugins.JavaBasePlugin$Inject class com.palantir.gradle.versions.VersionsLockPlugin class com.palantir.gradle.versions.VersionsPropsPlugin class com.palantir.gradle.versions.GetVersionPlugin class com.palantir.gradle.versions.ConsistentVersionsPlugin class org.owasp.dependencycheck.gradle.DependencyCheckPlugin class org.gradle.plugins.ide.eclipse.EclipsePlugin$Inject class de.undercouch.gradle.tasks.download.DownloadTaskPlugin ``` whereas after removing the palantir plugins, it'll give you this: ``` class org.gradle.api.plugins.HelpTasksPlugin$Inject class org.gradle.buildinit.plugins.BuildInitPlugin$Inject class org.gradle.buildinit.plugins.WrapperPlugin$Inject class org.gradle.language.base.plugins.LifecycleBasePlugin$Inject class org.gradle.api.plugins.BasePlugin$Inject class org.apache.lucene.gradle.buildinfra.BuildInfraPlugin class com.carrotsearch.gradle.dependencychecks.DependencyChecksPlugin class com.github.benmanes.gradle.versions.VersionsPlugin class org.owasp.dependencycheck.gradle.DependencyCheckPlugin class nl.littlerobots.vcu.plugin.VersionCatalogUpdatePlugin class de.undercouch.gradle.tasks.download.DownloadTaskPlugin ``` I think palantir's plugin has a side-effect of applying the java conventions to the root project [1], but it's not necessary - that's why I only apply it in the eclipse task, where it is required for the jdt. I've changed java-library to java-base though, it should have a minimal surface impact. [1] https://github.com/palantir/gradle-consistent-versions/blob/develop/src/main/java/com/palantir/gradle/versions/VersionsLockPlugin.java#L237-L239 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
