benwtrent commented on code in PR #13627: URL: https://github.com/apache/lucene/pull/13627#discussion_r1705880530
########## lucene/core/src/java/org/apache/lucene/index/DocumentsWriterDeleteQueue.java: ########## @@ -636,7 +636,7 @@ long getMaxSeqNo() { } /** Returns <code>true</code> if it was advanced. */ - boolean isAdvanced() { + synchronized boolean isAdvanced() { Review Comment: @jpountz synchronizing per your suggestion. Now isAdvanced and the action that can flip the boolean value are both synchronied. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org