seanmacavaney commented on issue #13634: URL: https://github.com/apache/lucene/issues/13634#issuecomment-2271094294
Thanks! I just opened a draft PR (#13635). To answer your questions: > The API, this is always tricky to get correct I've struggled a bit with this. The PR has an attempt, and I would totally appreciate feedback on it! > The seed query, will it be scored? How will we ensure there is a limit (e.g. that somebody doesn't just pass a match all docs query). Yes, it's scored. The PR sets a limit of 10 seed documents. (In contrast, HNSW uses a single entry point based on the hierarchical search.) This could also be something configurable, though I wouldn't want to complicate the API too much. > What should the behavior be when the seed query matches NO documents? I would assume the correct behavior here is to traverse the graph as normal. Yep, I agree that falling back on the default behavior is reasonable. This is what the PR implements. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org