dweiss commented on code in PR #13612:
URL: https://github.com/apache/lucene/pull/13612#discussion_r1693627976


##########
lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/Suggester.java:
##########
@@ -71,16 +76,26 @@ private Suggester(
    * entries are stored as fast-to-iterate plain words instead of highly 
compressed prefix trees.
    */
   public Suggester withSuggestibleEntryCache() {
-    return new Suggester(
-        dictionary, SuggestibleEntryCache.buildCache(dictionary.words), 
fragmentChecker);
+    SuggestibleEntryCache cache = 
SuggestibleEntryCache.buildCache(dictionary.words);
+    return new Suggester(dictionary, cache, fragmentChecker, proceedPastRep);
   }
 
   /**
    * Returns a copy of this suggester instance with {@link FragmentChecker} 
hint that can improve
    * the performance of the "Modification" phase performance.
    */
   public Suggester withFragmentChecker(FragmentChecker checker) {
-    return new Suggester(dictionary, suggestibleCache, checker);
+    return new Suggester(dictionary, suggestibleCache, checker, 
proceedPastRep);
+  }
+
+  /**
+   * Returns a copy of this suggester instance that doesn't stop after 
encountering acceptable words

Review Comment:
   It would be good to copy-paste this explanation to the PR's description, 
Peter. Explains what the patch is doing. I'll do this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to