epotyom commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1689382546
########## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/ordinal_iterators/CandidateSetOrdinalIterator.java: ########## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.lucene.sandbox.facet.ordinal_iterators; + +import java.io.IOException; +import org.apache.lucene.internal.hppc.IntHashSet; +import org.apache.lucene.sandbox.facet.abstracts.OrdinalIterator; + +/** + * {@link OrdinalIterator} that filters out ordinals from delegate if they are not in the candidate + * set. + * + * <p>Can be handy to get results only for specific facets. + */ +public class CandidateSetOrdinalIterator implements OrdinalIterator { Review Comment: We are planning to add more unit tests as a next step - but I'd suggest to do it in a follow up PR to contain size of current PR. I hope it's ok for sandbox module! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
