javanna commented on issue #12892: URL: https://github.com/apache/lucene/issues/12892#issuecomment-2245377653
I have been looking into this, there are unfortunately ~85 leftover usages of this method. Would be great to clean this up for Lucene 10. I opened a few small PRs around this. I think though that `FacetsCollector` needs extensive rework to leverage collector managers instead of collectors. I think it would be much simpler if the static search methods that `FacetsCollector` exposes took a `FacetsCollector` as last argument instead of a generic `Collector`. That seems to cover all of our internal usages, but I am not sure what the expectations are around users usage for such methods. We should discuss how we want to revisit the facets API as a whole. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
