uschindler commented on code in PR #13570: URL: https://github.com/apache/lucene/pull/13570#discussion_r1688093358
########## lucene/core/src/java21/org/apache/lucene/store/MemorySegmentIndexInputProvider.java: ########## @@ -125,4 +135,77 @@ private final MemorySegment[] map( } return segments; } + + @Override + public ConcurrentHashMap<String, RefCountedSharedArena> attachment() { + return new ConcurrentHashMap<>(); + } + + /** + * This sysprop allows to control the max number of permits that a RefCountedSharedArena will + * support for its lifetime. For example, to set the max number of permits to 256, pass the + * following on the command line pass {@code + * -Dorg.apache.lucene.store.MemorySegmentIndexInputProvider.sharedArenaMaxPermits=256}. Review Comment: The goog thing is you could make this constant into MMapDirectory and add it to documentation there (like done for the above in 9.x). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org