epotyom commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1679971693
########## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/abstracts/FacetLeafRecorder.java: ########## @@ -0,0 +1,31 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.lucene.sandbox.facet.abstracts; + +import java.io.IOException; + +/** Facets, that don't contain hits anymore, but */ +public interface FacetLeafRecorder { + + /** + * TODO: Rename: collect? accumulate? + * + * @param docId document ID + * @param facetId facet ordinal Review Comment: Yeah we use "facet ID" and "facet ordinal" interchangeably in this module, need to choose one and stick to it. I too like "ordinal" more because "ID" might make an impression that it is unique across all fields and data types. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
