uschindler commented on code in PR #13574:
URL: https://github.com/apache/lucene/pull/13574#discussion_r1679759640
##########
lucene/core/src/java/org/apache/lucene/store/Directory.java:
##########
@@ -177,7 +177,7 @@ public ChecksumIndexInput openChecksumInput(String name)
throws IOException {
public void copyFrom(Directory from, String src, String dest, IOContext
context)
Review Comment:
I think the change to Javadocs was mostly fine, maybe it should only be an
@implNote.
Maybe it should not be explicit and only say: The given IOContext is only
used for opening the destination file.
##########
lucene/test-framework/src/java/org/apache/lucene/tests/store/MockDirectoryWrapper.java:
##########
@@ -814,6 +814,14 @@ public synchronized IndexInput openInput(String name,
IOContext context) throws
context = LuceneTestCase.newIOContext(randomState, context);
final boolean confined = context == IOContext.READONCE;
+ if (name.startsWith(IndexFileNames.SEGMENTS) && confined == false) {
Review Comment:
Great!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
