Shradha26 commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1679672923
########## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/abstracts/FacetRecorder.java: ########## @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.lucene.sandbox.facet.abstracts; + +import java.io.IOException; +import org.apache.lucene.index.LeafReaderContext; + +/** + * Record data for each facet of each doc. TODO: do we need FacetRecorderManager similar to + * CollectorManager, e.g. is getLeafRecorder always thread safe? If we have a Manager-level + * recorder, then collection within a slice can be done to a single non-sync map, which must be + * faster. In our case, we didn't seem to benefit from it as we have more CPUs than segments in the + * index. Also, slice recorder makes it harder to implement lazy recorder init, as we need to init + * both slice and leaf recorders lazily. + */ +public interface FacetRecorder { + /** Get leaf recorder. */ + FacetLeafRecorder getLeafRecorder(LeafReaderContext context) throws IOException; + + /** Return next collected ordinal, or {@link FacetLeafCutter#NO_MORE_ORDS} */ + OrdinalIterator recordedOrds(); + + /** True if there are no records */ + boolean isEmpty(); + + /** + * Reduce leaf recorder results into this recorder. If facetRollup is not null, it also rolls up Review Comment: > I'd prefer if we had the same results in both cases I didn't follow this. Did you mean that we should always compute all the results for say a field like taxonomy, whether roll up is specified or not? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
