msokolov commented on PR #13566: URL: https://github.com/apache/lucene/pull/13566#issuecomment-2225970694
This version also applies the connectedness-checking and patching to concurrent graph build. It was a trivial addition. I tested and it seems to maybe help a bit: |test | recall | latency | index time | |-----------|--------|---------|------------| | baseline | 0.925 | 2.29 | 172225 | | baseline | 0.925 | 2.39 | 168809 | | candidate | 0.928 | 2.27 | 163188 | | candidate | 0.928 | 2.25 | 168005 | I still plan to try applying the strongly-connected graph check, so might want to hold off further testing until we have that. In theory it could suggest additional connections to add to the graph, although I suspect in practice its impact will be limited since what we seem to see is one big component (probably strongly connected?) plus a bunch of single disconnected nodes, but we'll see. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
