benwtrent commented on PR #13497: URL: https://github.com/apache/lucene/pull/13497#issuecomment-2221176325
Ok, I double checked, and indeed, half-byte is way slower when reading directly from memory segments instead of reading on heap. [memsegment_vs_baseline.zip](https://github.com/user-attachments/files/16167433/memsegment_vs_baseline.zip) The flamegraphs are wildly different. So much more time is being spent reading from memory segment and then comparing the vectors candidate (this PR): <img width="1607" alt="image" src="https://github.com/apache/lucene/assets/4357155/afa47bdd-3f53-4a27-8891-5e84ab32c0ed";> baseline: <img width="1610" alt="image" src="https://github.com/apache/lucene/assets/4357155/733913ca-1b2e-4e98-b8c4-18bf50787cca";> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
