jpountz commented on code in PR #13550:
URL: https://github.com/apache/lucene/pull/13550#discussion_r1669856325
##########
lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90DocValuesConsumer.java:
##########
@@ -96,6 +97,7 @@ public Lucene90DocValuesConsumer(
state.segmentInfo.getId(),
state.segmentSuffix);
maxDoc = state.segmentInfo.maxDoc();
+ this.skipIndexIntervalSize = skipIndexIntervalSize;
Review Comment:
Do we make any assumption anywhere that this needs to be a power of two? If
so we should validate it?
##########
lucene/core/src/test/org/apache/lucene/codecs/lucene90/TestLucene90DocValuesFormatVariableSkipInterval.java:
##########
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.lucene.codecs.lucene90;
+
+import org.apache.lucene.codecs.Codec;
+import org.apache.lucene.codecs.DocValuesFormat;
+import org.apache.lucene.codecs.lucene99.Lucene99Codec;
+import org.apache.lucene.tests.index.BaseDocValuesFormatTestCase;
+
+/** Tests Lucene90DocValuesFormat */
+public class TestLucene90DocValuesFormatVariableSkipInterval extends
BaseDocValuesFormatTestCase {
+
+ @Override
+ protected Codec getCodec() {
+ return new Lucene99Codec() {
+ @Override
+ public DocValuesFormat getDocValuesFormatForField(String name) {
+ return new Lucene90DocValuesFormat(random().nextInt(1 << 3, 1 << 10));
+ }
+ };
Review Comment:
Let's do `TestUtil.alwaysDocValuesFormat(new
Lucene90DocValuesFormat(random().nextInt(1 << 3, 1 << 10)))`? This will add
some assertions to the mix, and will make it easier when we bump the codec
version.
##########
lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90DocValuesFormat.java:
##########
@@ -138,15 +138,23 @@
*/
public final class Lucene90DocValuesFormat extends DocValuesFormat {
+ private final int skipIndexIntervalSize;
+
/** Default constructor. */
public Lucene90DocValuesFormat() {
+ this(DEFAULT_SKIP_INDEX_INTERVAL_SIZE);
+ }
+
+ /** Default constructor. */
Review Comment:
Nit: this is no longer the default ctor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
